Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional types with a new optional validator. #16

Closed
wants to merge 15 commits into from
Closed

Support optional types with a new optional validator. #16

wants to merge 15 commits into from

Conversation

@sam-falvo
Copy link

@sam-falvo sam-falvo commented Jul 7, 2015

No description provided.

Samuel A. Falvo II added 15 commits Jul 7, 2015
Unfortunately, I'm unable to run tests locally b/c of severe dependency
hell.  I am unable to get tox, detox, python setup.py test, and other
means of running tests to work at all.  So, since I'm blocked on a
project by the lack of optional validator support, I am going to close
my eyes, look away, and pull the trigger, and hope I hit the target.

If someone who has a working Python configuration can please be kind
enough to let me know if my changes fail any tests, I'd be very
appreciative.

Even better, I'd love to know why a stock Python distribution with
dependencies installed is incapable of running the tests for attrs.
However, this isn't the right forum to answer that question.
Recovering nested type info is just too hard and it makes the code ugly.
Just deal with nested reprs and hope for good coding practices.
@codecov-io
Copy link

@codecov-io codecov-io commented Jul 7, 2015

Current coverage is 100.0%

Merging #16 into master will change coverage by 0% by 9179ad9

Coverage Diff

@@            master     #16   diff @@
======================================
  Files            6       6       
  Stmts          298     309    +11
  Branches        59      61     +2
  Methods          0       0       
======================================
+ Hit            298     309    +11
  Partial          0       0       
  Missed           0       0       

Powered by Codecov

Loading

@sam-falvo sam-falvo closed this Jul 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants