Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow optional conversion #173
... or at least, provides the simplest possible solution to #105.
I went through the checklist; the only thing that I think is not done is the addition to the hypothesis testing strategy. I'm submitting and asking about that ;)
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
@@ Coverage Diff @@ ## master #173 +/- ## ===================================== Coverage 100% 100% ===================================== Files 8 9 +1 Lines 546 554 +8 Branches 121 122 +1 ===================================== + Hits 546 554 +8
Sorry no one got around to look at this yet! I'm currently busy preparing for a conference this weekend so my FLOSS activity is limited. I usually don't assign reviewers without good reason since that would be assigning work.
But In this case I'd like to ask @Tinche if this is what he had in mind before I review it once I have a free minute. If he does a full review: even better. ;)
We try to keep the PR queue as empty as possible; sorry you got caught in a bad moment!