Skip to content

/ attrs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the repr to work for non-redecorated subclass. #20

Merged
merged 1 commit into from Jul 22, 2015
Merged

Fix the repr to work for non-redecorated subclass. #20

merged 1 commit into from Jul 22, 2015

Conversation

@cyli
Copy link
Contributor

@cyli cyli commented Jul 21, 2015

Currently, if you subclass an @attr.s-decorated class without re-decorating with another @attr.s, the repr displays the name of the superclass, not the subclass.
@cyli
If you subclass an attr class, the repr should include the name of th…
Loading status checks…
b3ef284 
…e subclass, not the superclass, even if you don't redecorate with another @attr.s
@codecov-io
Copy link

@codecov-io codecov-io commented Jul 21, 2015

Current coverage is 100.0%

Merging #20 into master will not affect coverage as of 17e5460

@@            master     #20   diff @@
======================================
  Files            6       6       
  Stmts          299     299       
  Branches        59      59       
  Methods          0       0       
======================================
  Hit            299     299       
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff

Powered by Codecov
hynek added a commit that referenced this pull request Jul 22, 2015
@hynek
Merge pull request #20 from cyli/subclass-repr
Loading status checks…
c6e2f1f 
Fix the repr to work for non-redecorated subclass.
@hynek hynek merged commit c6e2f1f into python-attrs:master Jul 22, 2015
3 checks passed
3 checks passed
codecov/commit 100.00% (min required 100%)
Details
codecov/project 100.00% (min required 100%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hynek
Copy link
Member

@hynek hynek commented Jul 22, 2015

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@cyli @codecov-io @hynek
You can’t perform that action at this time.