Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix MRO traversal with multiple inheritance #304
So the double reversal we used to do screwed up the MRO traversal for forever (i.e. this is not a 17.3 regression, I had to fix examples.rst!).
This fixes it – the question is how we go about it. A proper deprecation cycle seems impossible again, so I guess we can push it and ask for forgiveness?
@@ Coverage Diff @@ ## master #304 +/- ## ===================================== Coverage 100% 100% ===================================== Files 9 9 Lines 733 729 -4 Branches 152 151 -1 ===================================== - Hits 733 729 -4
Dec 13, 2017
referenced this pull request
Dec 15, 2017
added a commit
this pull request
Dec 27, 2017
Somewhat belatedly (although it appears in time for a release?) I did have an idea about this.
The deprecation cycle here could go like this:
Alternately, if we just want to bite the bullet, we could switch to this behavior, but still emit a warning for a release or two about using positional args in the multiple-inheritance case.
This might help folks with deep inheritance trees at least notice that there might be a problem if their test coverage isn't great.