Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Annotate __init__ with type hints #363
This just adds the annotations found at run-time to the
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
@@ Coverage Diff @@ ## master #363 +/- ## ===================================== Coverage 100% 100% ===================================== Files 9 9 Lines 825 830 +5 Branches 173 174 +1 ===================================== + Hits 825 830 +5
I'm super excited - this would be awesome for Hypothesis even before HypothesisWorks/hypothesis#954 -
so I've left some comments below on how to make that work well. No pressure though, because we do want to add a tighter integration from our end (eventually!) which would bypass this work.
Yes, this is good to go. The only minor disagreement we have is that David decided not to fill in
I think we could do better than giving up in this scenario but we can iterate on this in a future version. I agree with David that doing it comprehensively is a rather complex project.
So, +1 from me as is.