Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress HealthCheck.too_slow for test_not_none_metadata #364

Closed
wants to merge 2 commits into from

Conversation

@mattst88
Copy link

@mattst88 mattst88 commented Mar 27, 2018

On very slow hardware, these may time out.

Bug: https://bugs.gentoo.org/651794

On very slow hardware, these may time out.

Bug: https://bugs.gentoo.org/651794
@codecov
Copy link

@codecov codecov bot commented Mar 27, 2018

Codecov Report

Merging #364 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #364   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         831    831           
  Branches      174    174           
=====================================
  Hits          831    831

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8274c9f...720dd35. Read the comment docs.

@wsanchez
Copy link

@wsanchez wsanchez commented Mar 28, 2018

It might be better to have a global thing like:

settings.register_profile(
    "patience", settings(suppress_health_check=[HealthCheck.too_slow])
)
settings.load_profile("patience")

And make the load_profile call conditional on an environment variable, rather than trying to suppress this for specific tests. (All tests will time out on slow enough hardware.)

@hynek
Copy link
Member

@hynek hynek commented Apr 5, 2018

Yeah I think I agree with @wsanchez here. Trying to suppress only certain tests is a game of whac-a-mole. It should be all or none.

@leio
Copy link

@leio leio commented May 4, 2018

Then push the relevant changes please?

@wsanchez
Copy link

@wsanchez wsanchez commented May 4, 2018

@hynek: Should we suppress these all the time or try to limit that to CI environments (eg. "CI" env var is set)? I kinda lean towards the former; wall-clock timeouts like these aren't my favorite.

@hynek
Copy link
Member

@hynek hynek commented May 5, 2018

Hm ISTM that it’s kind of a feature in local dev that some tests are not optimal.

So I’d tend to an env var. But would like input from @Tinche and @DRMacIver on it.

hynek added a commit that referenced this pull request Jun 17, 2018
@Tinche Tinche closed this in #396 Jun 17, 2018
Tinche added a commit that referenced this pull request Jun 17, 2018
* Disable hypothesis.HealthCheck.too_slow globally

Fixes #364

* Add newsfragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.