Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise DeprecationWarning when comparing subclasses #394

Merged
merged 3 commits into from Jun 16, 2018
Merged

Conversation

@hynek
Copy link
Member

@hynek hynek commented Jun 16, 2018

Fixes #387

The docs were always clear on this:

But the attributes are only compared, if the type of both classes is identical!

(which sounds weird, so I fix it in this PR too)

@codecov
Copy link

@codecov codecov bot commented Jun 16, 2018

Codecov Report

Merging #394 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #394   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         835    844    +9     
  Branches      174    178    +4     
=====================================
+ Hits          835    844    +9
Impacted Files Coverage Δ
src/attr/_make.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c41470...edacf35. Read the comment docs.

@hynek hynek force-pushed the deprecate-subclass-cmp branch from 92544dc to 4a395b1 Jun 16, 2018
@hynek hynek force-pushed the deprecate-subclass-cmp branch from 4a395b1 to edacf35 Jun 16, 2018
Copy link

@wsanchez wsanchez left a comment

LGTM

@hynek hynek merged commit 2834ee4 into master Jun 16, 2018
4 checks passed
4 checks passed
@codecov
codecov/patch 100% of diff hit (target 100%)
Details
@codecov
codecov/project 100% (+0%) compared to 9c41470
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@hynek hynek deleted the deprecate-subclass-cmp branch Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants