New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override class vars of super classes w/ annotations #431

Merged
merged 3 commits into from Aug 27, 2018

Conversation

Projects
None yet
2 participants
@hynek
Member

hynek commented Aug 21, 2018

This is the best I could come up with for #427. Am I missing some weird edge case here? I’m afraid to silence some legit error but can’t think of a better way.

Fixes #427

hynek added some commits Aug 21, 2018

@hynek

This comment has been minimized.

Member

hynek commented Aug 26, 2018

JFTR this is the final release blocker for 18.2. I will not release it until this is resolved.

# This can happen if a superclass defines a class
# variable and we want to set an attribute with the
# same name by using only a type annotation.
pass

This comment has been minimized.

@ambv

ambv Aug 27, 2018

Contributor

Won't this also happen if the base class has a method of that name?

@ambv

ambv approved these changes Aug 27, 2018

This looks sensible.

@hynek hynek merged commit 746f047 into master Aug 27, 2018

4 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (target 100%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hynek hynek deleted the super-class-vars branch Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment