Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override class vars of super classes w/ annotations #431

merged 3 commits into from Aug 27, 2018


Copy link

@hynek hynek commented Aug 21, 2018

This is the best I could come up with for #427. Am I missing some weird edge case here? I’m afraid to silence some legit error but can’t think of a better way.

Fixes #427

Copy link
Member Author

hynek commented Aug 26, 2018

JFTR this is the final release blocker for 18.2. I will not release it until this is resolved.

# This can happen if a superclass defines a class
# variable and we want to set an attribute with the
# same name by using only a type annotation.

This comment was marked as spam.

Copy link

@ambv ambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible.

@hynek hynek merged commit 746f047 into master Aug 27, 2018
@hynek hynek deleted the super-class-vars branch August 27, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants