Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code and tests related to deprecated 'convert' kwarg #504

Merged
merged 5 commits into from Mar 7, 2019

Conversation

@ramatevish
Copy link
Contributor

@ramatevish ramatevish commented Feb 14, 2019

  • Added tests for changed code.
  • New features have been added to our Hypothesis testing strategy.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file tests/typing_example.py.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changes to the signature of @attr.s() have to be added by hand too.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
  • Documentation in .rst files is written using semantic newlines.
  • Changes (and possible deprecations) have news fragments in changelog.d.
@ramatevish
Copy link
Contributor Author

@ramatevish ramatevish commented Feb 14, 2019

Woof, I'm pretty sure this is failing tests because pytest itself uses attrs and is still using the depreciated kwarg.

@ramatevish
Copy link
Contributor Author

@ramatevish ramatevish commented Feb 14, 2019

@hynek
Copy link
Member

@hynek hynek commented Feb 14, 2019

Nice!

I think I want to push 19.1 first with convert in place and emerge right after.

@ramatevish
Copy link
Contributor Author

@ramatevish ramatevish commented Mar 5, 2019

Updated now that pytest isn't breaking.

hynek
hynek approved these changes Mar 7, 2019
@hynek hynek merged commit c2a9dd8 into python-attrs:master Mar 7, 2019
1 check passed
@hynek
Copy link
Member

@hynek hynek commented Mar 7, 2019

Thank you very much, I love the smell of deleted code in the morning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants