Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support on azure-pipelines.yml #511

Closed

Conversation

Projects
None yet
2 participants
@tonybaloney
Copy link

commented Mar 3, 2019

Starting a WIP PR just so I can see the build status

tonybaloney added some commits Mar 3, 2019

@tonybaloney tonybaloney changed the title [WIP] Support on azure-pipelines.yml Support on azure-pipelines.yml Mar 3, 2019

@tonybaloney

This comment has been minimized.

Copy link
Author

commented Mar 3, 2019

@hynek once you change https://github.com/python-attrs/attrs/pull/511/files#diff-fec826feae04e51c0d94076385408bdcR42 with the actual token this build should work :-)

@tonybaloney

This comment has been minimized.

Copy link
Author

commented Mar 3, 2019

Also, you might want to make pytest-azurepipelines optional in tox.ini, since the regular user doesn't need it

@hynek

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

@hynek once you change https://github.com/python-attrs/attrs/pull/511/files#diff-fec826feae04e51c0d94076385408bdcR42 with the actual token this build should work :-)

I presume you mean the CODECOV_TOKEN? that's a secret variable in Azure Pipelines; is it not available if someone else runs it? I guess that makes sense, since you could open a PR that just sends a token to yourself? What is the correct way here? I don't want to put it there in cleartext?

The build fails because of trailing whitespace btw.

@tonybaloney

This comment has been minimized.

Copy link
Author

commented Mar 3, 2019

Ah, that makes more sense if the variable is scoped to only contributors. In that case, you can keep my changes to the codecov job or scrap them. Fixed the trailing whitespace

- script: tox -e typing
displayName: run tox for typing

- script: tox -e lint,docs

This comment has been minimized.

Copy link
@hynek

hynek Mar 3, 2019

Member

any reason why you grouped these together?

@hynek

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

Ah, that makes more sense if the variable is scoped to only contributors. In that case, you can keep my changes to the codecov job or scrap them. Fixed the trailing whitespace

Yeah but that's kinda bad, because contributors won't get feedback on coverage. :|

I believe I saw something that AP might have their own solution to coverage? Do you know anything about it? Is it ready?

@tonybaloney

This comment has been minimized.

Copy link
Author

commented Mar 3, 2019

I have a solution for coverage gap. Bear with me 🐻

@hynek

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

giphy

tonybaloney added some commits Mar 4, 2019

@tonybaloney

This comment has been minimized.

Copy link
Author

commented Mar 4, 2019

@hynek checkout https://attrs.visualstudio.com/attrs/_build/results?buildId=37&view=results and see the summary tab you'll see ~70% coverage, you can download the coverage report ZIP file in the summary page as well, and click on lines to see details.

@hynek

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

We’ve got 100% coverage though. Is this coverage from only one particular run (maybe just py2 or just py3)?

@hynek

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

Yeah something is going very wrong:

image

Note the py34, but even that isn't correct. But this might be just us using pytest-cov wrong? I think there was a way to achieve https://hynek.me/articles/testing-packaging/ w/ pytest-cov? 🤔

@hynek

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

Ah so one think I just noticed: we have special envs for 2.7 and 3.7 because that determines our coverage. The rest of our tox envs used to run w/o coverage for performance reasons (especially PyPy).

With your changes you run the tests that used to not run with coverage with pytest-cov and you've left the coverage-envs using the old way that probably gets ignored?

Is it even possible to combine coverages over multiple runs into AP coverage?

P.S. thanks for all your efforts!

@hynek

This comment has been minimized.

Copy link
Member

commented May 14, 2019

thanks for everything, we're on AP now! I think/hope I got all missing things from your PR over time. :)

@hynek hynek closed this May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.