New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests, bandage assoc. #84

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Tinche
Member

Tinche commented Sep 9, 2016

Ok, here's something easy to merge.

I've done some work on the simple_classes strategy. It's somewhat documented, takes some parameters, and implemented in a clearer way. This is in the hopes it will get used more by other contributors in tests.

I've then applied this strategy to assoc tests. The tests picked up failures right away. I've applied a dumb fix to assoc to make slot classes pass.

The tests picked up another failure though: if a class is both slots and frozen, assoc will fail deep in copy.copy. This isn't so easily fixed.

Plot twist!

Digging around in the source of copy.copy, I see mentions of pickling. Applying these changes on to #81 allows copy.copy() to copy slots+frozen classes.

Improve tests, bandage assoc.
Refactored and documented the simple_classes strategy. Applied the strategy to assoc tests.
@hynek

This comment has been minimized.

Member

hynek commented Sep 10, 2016

Merged in 1897dfd.

@hynek hynek closed this Sep 10, 2016

@Tinche Tinche deleted the Tinche:bugfix/assoc-work branch Jan 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment