"ValueError: expected only letters, got u'ko-kr'"

[ajaeger]

With Babel 2.4.0 we get:
File "/home/jenkins/workspace/openstack-manuals-tox-doc-publishlang/.tox/venv/local/lib/python2.7/site-packages/babel/core.py", line 1093, in parse_locale
"ValueError: expected only letters, got u'ko-kr'"

This comes from using "ko-kr" as locale in http://git.openstack.org/cgit/openstack/openstack-manuals/tree/doc/install-guide/source/locale/ko_KR/LC_MESSAGES/install-guide.po#n42

We didn't have this problem with earlier Babel releases.

Other places in Babel accept the '-' like https://github.com/python-babel/babel/blob/v2.4.0/tests/test_core.py#L100 - why not here as well and break existing files this way?

[akx]

Hi!

The default separator for parse_locale() is the underscore, so in your case the locale name should be ko_KR.

The location you linked, https://github.com/python-babel/babel/blob/v2.4.0/tests/test_core.py#L100, explicitly passes sep='-', which is why it works.

The behavior of parse_locale() has not changed between 2.3.4 and 2.4.0; the last changes to that code are from 2008. :)

[ajaeger]

@akx, while parse_locale() has not changed, 08b9c5e now parses the po file which did not happen before - and thus introduces the problem.

[akx]

Ahhh, right you are! Didn't think about that.

[akx]

I'll wait for a while before cutting 2.4.1, in case there are other bug reports.

[ajaeger]

Thanks a lot @akx !