Skip to content

Release 2.5.2 is not backward compatible #550

Closed

Description

@chessbr

The last release includes this commit cf03578 which changes the NumberPattern.apply signature from

def apply(self, value, locale, currency=None, force_frac=None):

to

def apply(self, value, locale, currency=None, currency_digits=True):

chopping out the force_frac param.

Is this project following semver? Our build started to break on version 2.x. If this is not the case I can just fix the version on our project for now until we update the project.

Thanks

Activity

  1. akx commented on Jan 15, 2018

    @akx
    Member

    Hey @chessbr!

    Yeah, that was not the intention, even if Babel currently does not strictly follow semver. (The plan is to start doing so when version 3 eventually rolls out.)
    I should've paid more close attention to the commit history and cut 2.5.2 from an earlier commit instead of master.

    I'll cut release 2.5.3 from 2.5.1 + the PyInstaller fix (#533)...

    Sorry about the inconvenience!

  2. chessbr commented on Jan 15, 2018

    @chessbr
    Author

    No problem @akx !
    Thank you for the support!

  3. akx commented on Jan 15, 2018

    @akx
    Member

    Version 2.5.3, which is v2.5.1 + 7cedb84, 29da2d2, and edfb518, has been pushed to PyPI.

    Once again, sorry about the screw-up! 😥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions