New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.5.2 is not backward compatible #550

Closed
chessbr opened this Issue Jan 15, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@chessbr

chessbr commented Jan 15, 2018

The last release includes this commit cf03578 which changes the NumberPattern.apply signature from

def apply(self, value, locale, currency=None, force_frac=None):

to

def apply(self, value, locale, currency=None, currency_digits=True):

chopping out the force_frac param.

Is this project following semver? Our build started to break on version 2.x. If this is not the case I can just fix the version on our project for now until we update the project.

Thanks

@akx

This comment has been minimized.

Member

akx commented Jan 15, 2018

Hey @chessbr!

Yeah, that was not the intention, even if Babel currently does not strictly follow semver. (The plan is to start doing so when version 3 eventually rolls out.)
I should've paid more close attention to the commit history and cut 2.5.2 from an earlier commit instead of master.

I'll cut release 2.5.3 from 2.5.1 + the PyInstaller fix (#533)...

Sorry about the inconvenience!

@chessbr

This comment has been minimized.

chessbr commented Jan 15, 2018

No problem @akx !
Thank you for the support!

@akx

This comment has been minimized.

Member

akx commented Jan 15, 2018

Version 2.5.3, which is v2.5.1 + 7cedb84, 29da2d2, and edfb518, has been pushed to PyPI.

Once again, sorry about the screw-up! 😥

@akx akx closed this Jan 15, 2018

akx added a commit to akx/babel that referenced this issue May 7, 2018

Restore force_frac to NumberPattern.apply(), as deprecated
This retains backwards compatibility (at least as far as the function's
signature is concerned) with users that are using NumberPattern.apply()
directly.

See: python-babel#550
See: python-babel#569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment