New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'Language' header field of PO files #110

Merged
merged 1 commit into from Aug 5, 2015

Conversation

Projects
None yet
4 participants
@felixonmars
Contributor

felixonmars commented Sep 6, 2014

I only adjusted the tests based on @dmbasso's branch. Let me know if anything else is needed to get this merged.

@felixonmars felixonmars changed the title from fix for missing Language header to fix for missing Language header (with tests) Sep 6, 2014

@sils

This comment has been minimized.

Member

sils commented Aug 5, 2015

hey, the tests and the feature belong together, right? So could you squash the commits? (You can use git rebase --interactive)

Also this needs a rebase which will probably fix the tests.

Can you adjust your commit message so it explains the change and not the fix? Is there any issue? Please place a reference to the issue describing the problem. If there is no issue, could you create one?

More information about a good commit message style is available on http://coala.readthedocs.org/en/latest/Getting_Involved/Writing_Good_Commits/#how-to-write-good-commit-messages .

Support 'Language' header field of PO files (#76)
GNU gettext has support for the 'Language' field in header entry since
version 0.18 (May 2010). This commit adds support for the field and
addresses #76.
@felixonmars

This comment has been minimized.

Contributor

felixonmars commented Aug 5, 2015

Hi, thanks for the hint :)

I have squashed the commits and rebased to current master. Please let me know if anything is still missing, thanks!

@codecov-io

This comment has been minimized.

codecov-io commented Aug 5, 2015

Current coverage is 82.93%

Merging #110 into master will increase coverage by +0.01% as of 7ca606b

@@            master    #110   diff @@
======================================
  Files           21      21       
  Stmts         3770    3772     +2
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           3126    3128     +2
  Partial          0       0       
  Missed         644     644       

Review entire Coverage Diff

Powered by Codecov

@sils

This comment has been minimized.

Member

sils commented Aug 5, 2015

lgtm, @erickwilder can you take a short look and merge?

@felixonmars felixonmars changed the title from fix for missing Language header (with tests) to Support 'Language' header field of PO files Aug 5, 2015

@erickwilder

This comment has been minimized.

Contributor

erickwilder commented Aug 5, 2015

Looks good

erickwilder added a commit that referenced this pull request Aug 5, 2015

Merge pull request #110 from felixonmars/master
Support 'Language' header field of PO files

@erickwilder erickwilder merged commit 56c59d5 into python-babel:master Aug 5, 2015

5 checks passed

codecov/commit 100.00% (min required 80.00%)
Details
codecov/patch 100.00% (min required 80.00%)
Details
codecov/project 82.93% (min required 80.00%)
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment