Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a callable to extract() #289

Merged
merged 1 commit into from
Dec 20, 2015

Conversation

akx
Copy link
Member

@akx akx commented Dec 20, 2015

This makes it much easier to do create custom extraction machinery without having to bother with external configuration files or Setuptools entry points.

@sils
Copy link
Member

sils commented Dec 20, 2015

@akx hey, thanks for trying to help us! Please note that we're short of manpower, if you'd like to help please also consider reviewing other peoples PRs.

Your commit seems not to be compatible with Python 3.3 and lower, see https://travis-ci.org/python-babel/babel/jobs/97957737 . Could you fix that?

@akx
Copy link
Member Author

akx commented Dec 20, 2015

My bad for not running tests on Py3! (Turns out it was an one byte fix ("" to b"").

Anyway, I'd be glad to help in other ways too. :)

@sils
Copy link
Member

sils commented Dec 20, 2015

@akx awesome, just pick one or a few of https://github.com/python-babel/babel/pulls?q=is%3Aopen+is%3Apr+label%3A%22%283%29+pending+review%22 , if you think the PR is good for the project, drop a comment. General rules, all tests must pass of course, more coverage is good, good commit messages are valued.

@codecov-io
Copy link

Current coverage is 83.44%

Merging #289 into master will increase coverage by +0.06% as of 0fe3701

@@            master    #289   diff @@
======================================
  Files           22      22       
  Stmts         3756    3758     +2
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           3132    3136     +4
  Partial          0       0       
+ Missed         624     622     -2

Review entire Coverage Diff as of 0fe3701

Powered by Codecov. Updated on successful CI builds.

sils added a commit that referenced this pull request Dec 20, 2015
Allow passing a callable to `extract()`
@sils sils merged commit 2a51c9b into python-babel:master Dec 20, 2015
@sils
Copy link
Member

sils commented Dec 20, 2015

Thanks! Added note to https://github.com/python-babel/babel/wiki/CHANGES

@sils
Copy link
Member

sils commented Dec 20, 2015

@akx you might want to join our chat at https://gitter.im/python-babel/babel :)

@akx akx deleted the allow-extract-callable branch December 30, 2015 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants