Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day period API #349

Merged
merged 4 commits into from Mar 9, 2016
Merged

Day period API #349

merged 4 commits into from Mar 9, 2016

Conversation

@akx
Copy link
Member

@akx akx commented Feb 15, 2016

This PR adds full support for day periods other than am/pm.

Requested by @sachinpali146 for additional time format character support. :)

See: http://unicode.org/reports/tr35/tr35-dates.html#Day_Period_Rules

@codecov-io
Copy link

@codecov-io codecov-io commented Feb 15, 2016

Current coverage is 89.71%

Merging #349 into master will increase coverage by +0.01% as of 910f20c

@@            master    #349   diff @@
======================================
  Files           23      23       
  Stmts         3808    3840    +32
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           3416    3445    +29
  Partial          0       0       
- Missed         392     395     +3

Review entire Coverage Diff as of 910f20c

Powered by Codecov. Updated on successful CI builds.

akx added 4 commits Feb 14, 2016
* Day period rules are now imported
* All periods (not just a single context/width) are imported
@akx akx force-pushed the akx:import-day-periods branch from e599747 to 151fda9 Mar 5, 2016
@RauliL
Copy link

@RauliL RauliL commented Mar 9, 2016

LGTM.

@akx
Copy link
Member Author

@akx akx commented Mar 9, 2016

(@RauliL is a colleague who I recruited to do code review here.)

akx added a commit that referenced this pull request Mar 9, 2016
Day period API
@akx akx merged commit f5bd94d into python-babel:master Mar 9, 2016
4 of 6 checks passed
4 of 6 checks passed
review/gitmate/commit GitMate is currently running the analysis for this commit.
Details
review/gitmate/manual This commit needs review.
Details
codecov/patch 92.00% of diff hit (target 80.00%)
Details
codecov/project 89.71% (+0.01%) compared to 8fe06db at 89.70%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akx akx deleted the akx:import-day-periods branch Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants