New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix day period formatting (#378) #379

Merged
merged 2 commits into from Apr 8, 2016

Conversation

Projects
None yet
4 participants
@akx
Member

akx commented Apr 8, 2016

See issue #378 for discussion.

We should release 2.3.2 when this fix is in, if no other bugs/regressions are found.

akx added some commits Apr 8, 2016

dates: Use format context and fallback through widths
`zh_Hant` locale data does not have names for the
`am` and `pm` day periods in the `format`/`abbreviated` context,
so fallback logic is added to deal with that eventuality.

Fixes #378

@akx akx force-pushed the akx:fix-378 branch from 7f0d63a to 971e706 Apr 8, 2016

@codecov-io

This comment has been minimized.

codecov-io commented Apr 8, 2016

Current coverage is 89.34%

Merging #379 into master will decrease coverage by -0.62% as of e4604e9

@@            master    #379   diff @@
======================================
  Files           24      24       
  Stmts         3927    3931     +4
  Branches         0       0       
  Methods          0       0       
======================================
- Hit           3533    3512    -21
  Partial          0       0       
- Missed         394     419    +25

Review entire Coverage Diff as of e4604e9

Powered by Codecov. Updated on successful CI builds.

@akx

This comment has been minimized.

Member

akx commented Apr 8, 2016

I kinda want the same stuff @codecov-io is smoking...

@akx

This comment has been minimized.

Member

akx commented Apr 8, 2016

Self-merging as this is a regression fix.

The only failing CI is Codecov, which is on some sort of robot drugs... as usual.

@akx akx merged commit e4ae94c into python-babel:master Apr 8, 2016

5 of 7 checks passed

codecov/project 89.34% (-0.62%) compared to 5aa21f9 at 89.96%
Details
review/gitmate/manual This commit needs review.
Details
codecov/patch 80.00% of diff hit (target 80.00%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/pr All is well! :) (0 problems solved)
Details

@akx akx deleted the akx:fix-378 branch Apr 8, 2016

@pyup-bot pyup-bot referenced this pull request Apr 11, 2017

Open

Initial Update #3

@pyup-bot pyup-bot referenced this pull request May 12, 2017

Closed

Initial Update #43

@pyup-bot pyup-bot referenced this pull request Jul 4, 2017

Merged

Initial Update #2

@pyup-bot pyup-bot referenced this pull request Nov 3, 2017

Closed

Update babel to 2.5.1 #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment