Use CLDR 29 #405
Merged
Use CLDR 29 #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitmate-bot
added
pending review
process/pending review
size/M
and removed
pending review
labels
Current coverage is 90.13%
@@ master #405 diff @@
==========================================
Files 24 24
Lines 3951 3954 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3562 3564 +2
- Misses 389 390 +1
Partials 0 0
|
| @@ -9,7 +9,7 @@ | |||
| ("de", time(7, 42), "morning1"), # (from, before) | |||
| ("de", time(3, 11), "night1"), # (after, before) | |||
| ("fi", time(0), "midnight"), # (at) | |||
| ("en_US", time(12), "noon"), # (at) | |||
| ("en", time(12), "noon"), # (at) | |||
There was a problem hiding this comment.
Why did this change? Purely to make the tests consistent?
ETA: OIC, dayPeriods.xml only has per-language definitions so far. I don't think it's a bad idea to check locale (eg en_US) inheritance from the language (eg en)
There was a problem hiding this comment.
Good point. I'm actually not sure why I changed that...
|
Thanks for tackling this! I expected there to be waaaay more changes, it's awesome that there aren't! I am kind of bummed that zh_Hant is still missing am/pm from it's abbreviated day period definitions. :P |
|
@jtwang Rebased and fixed that en_US thing. |
|
ack 34c92cb Looks good, merge! (What's the worst that can happen ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything... seems to work, at least!
Fixes #404