Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage of JSX extraction tests #425

Merged
merged 1 commit into from
Nov 19, 2016

Conversation

georgschoelly
Copy link
Contributor

@georgschoelly georgschoelly commented Jun 25, 2016

b5e0ad8 fixed a few bugs with jsx parsing but only added
tests for the lexer. This commit adds a test for the extraction
which did not work before:

<tag>{ _"Text" }</tag>

This test case is not present yet in the suite, only tags with
attributes (<tag attr="value">) are, but they get extracted correctly
already.

@codecov-io
Copy link

codecov-io commented Jun 25, 2016

Current coverage is 90.10% (diff: 100%)

Merging #425 into master will not change coverage

@@             master       #425   diff @@
==========================================
  Files            24         24          
  Lines          3951       3951          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           3560       3560          
  Misses          391        391          
  Partials          0          0          

Powered by Codecov. Last update f8b62e5...fd35147

@akx
Copy link
Member

akx commented Nov 19, 2016

Hi @georgschoelly -- I'd love to merge this PR, but tests currently don't pass due to a CI configuration issue (not your fault!). Can you either rebase this on top of the current master or alternatively check the "Allow maintainers to edit" checkbox on the right? 👉

@georgschoelly
Copy link
Contributor Author

georgschoelly commented Nov 19, 2016

I checked the box, as I currently don't have an active project with python-babel. Thanks for your work!

b5e0ad8 fixed a few bugs with jsx parsing but only added
tests for the lexer. This commit adds a test for the extraction
which did not work before:

    <tag>{ _"Text" }</tag>

This test case is not present yet in the suite, only tags with
attributes (<tag attr="value">) are, but they get extracted correctly
already.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants