New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python message extractor respects unicode_literals in __future__ #427

Merged
merged 1 commit into from Jul 9, 2016

Conversation

Projects
None yet
4 participants
@sublee
Contributor

sublee commented Jul 1, 2016

This patch fixes #426.

@codecov-io

This comment has been minimized.

codecov-io commented Jul 1, 2016

Current coverage is 90.19%

Merging #427 into master will increase coverage by 0.03%

@@             master       #427   diff @@
==========================================
  Files            24         24          
  Lines          3961       3977    +16   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3571       3587    +16   
  Misses          390        390          
  Partials          0          0          

Powered by Codecov. Last updated by 9a3ce80...60d13b0

@akx

This comment has been minimized.

Member

akx commented Jul 8, 2016

The two commits should be squashed into one, since the second seems to just add Py3.5 compatibility which was lacking in the first commit.

Looks fine to me otherwise. :)

Fix #426
Parse compiler flags based on __future__ imports in Python codes.
Evaluate a string literal with the parsed compiler flags.
@sublee

This comment has been minimized.

Contributor

sublee commented Jul 9, 2016

@akx Thank you for reviewing my patch. I squashed my commits as you advised. Please review again.

@akx akx merged commit d6ed896 into python-babel:master Jul 9, 2016

6 of 7 checks passed

review/gitmate/manual This commit needs review.
Details
codecov/patch 100% of diff hit (target 80.00%)
Details
codecov/project 90.19% (+0.03%) compared to 9a3ce80
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit No issues with this one - go ahead! :)
Details
review/gitmate/pr All is well! :) (1 problems solved)
Details
@akx

This comment has been minimized.

Member

akx commented Jul 9, 2016

Thanks for the patch, @sublee! :)

@sublee

This comment has been minimized.

Contributor

sublee commented Jul 9, 2016

@akx Thank you for accepting it! :)

akx added a commit to akx/babel that referenced this pull request Aug 18, 2017

akx added a commit that referenced this pull request Aug 21, 2017

Parse multi-line __future__ imports better
Augments #426

Augments #427

Augments #510

akx added a commit to akx/babel that referenced this pull request Aug 21, 2017

akx added a commit that referenced this pull request Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment