Python message extractor respects unicode_literals in __future__ #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitmate-bot
added
process/pending review
pending review
size/S
and removed
process/pending review
labels
Current coverage is 90.19%@@ master #427 diff @@
==========================================
Files 24 24
Lines 3961 3977 +16
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3571 3587 +16
Misses 390 390
Partials 0 0
|
|
The two commits should be squashed into one, since the second seems to just add Py3.5 compatibility which was lacking in the first commit. Looks fine to me otherwise. :) |
Parse compiler flags based on __future__ imports in Python codes. Evaluate a string literal with the parsed compiler flags.
|
@akx Thank you for reviewing my patch. I squashed my commits as you advised. Please review again. |
|
Thanks for the patch, @sublee! :) |
|
@akx Thank you for accepting it! :) |
akx
added a commit
to akx/babel
that referenced
this pull request
Aug 18, 2017
Augments python-babel#426 Augments python-babel#427 Augments python-babel#510
akx
added a commit
to akx/babel
that referenced
this pull request
Aug 21, 2017
Augments python-babel#426 Augments python-babel#427 Augments python-babel#510
akx
added a commit
that referenced
this pull request
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #426.