Add option 'add_location' for location line formatting #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitmate-bot
added
process/pending review
pending review
size/M
and removed
process/pending review
labels
Current coverage is 90.18% (diff: 100%)@@ master #438 diff @@
==========================================
Files 24 24
Lines 3954 3963 +9
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3565 3574 +9
Misses 389 389
Partials 0 0
|
Support of add_location option added, can be either 'full', 'file' or 'never'. 'full' includes both file and line number; 'file' includes only the file name without line number; 'never' doesn't include the location comment at all (same as --no-location).
rrader
force-pushed
the
add_location_option
branch
from
5de9ee4
to
2ff0f48
Compare
akx
approved these changes
Nov 21, 2016
|
|
||
| def initialize_options(self): | ||
| self.charset = 'utf-8' | ||
| self.keywords = None | ||
| self.no_default_keywords = False | ||
| self.mapping_file = None | ||
| self.no_location = False | ||
| self.add_location = None |
There was a problem hiding this comment.
This basically defaults to 'full' though, doesn't it?
| self.no_location = True | ||
| elif self.add_location == 'file': | ||
| self.include_lineno = False | ||
|
|
There was a problem hiding this comment.
It might be worth it to del self.add_location here, as the variable has already served its purpose and further modifications to it will not have any effect.
|
Thanks for the patch, @rrader! :) Much appreciated. |
|
@akx, hello! When will be the new release with this patch?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support of add_location option added, can be either 'full', 'file'
or 'never'. 'full' includes both file and line number; 'file' includes
only the file name without line number; 'never' doesn't include the
location comment at all (same as --no-location).
Python babel implementation lacks of this option. We would like to use it to avoid merge conflicts while merging po files.
Option
add_locationis implemented in the GNU xgettext, quote from the manual:https://www.gnu.org/software/gettext/manual/html_node/xgettext-Invocation.html