Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Python messages in nested gettext calls #488

Merged
merged 4 commits into from Mar 31, 2017

Conversation

sublee
Copy link
Contributor

@sublee sublee commented Mar 31, 2017

This patch fixes #487.

There're only one small change and complex test cases.

@codecov-io
Copy link

Codecov Report

Merging #488 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage   90.16%   90.17%   +<.01%     
==========================================
  Files          24       24              
  Lines        3975     3978       +3     
==========================================
+ Hits         3584     3587       +3     
  Misses        391      391
Impacted Files Coverage Δ
babel/messages/extract.py 94.94% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23adb4f...b96c84e. Read the comment docs.

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautifully simple modification to the extractor, and a great test case 🎉

@akx akx merged commit bdf5876 into python-babel:master Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract Python messages in nested gettext calls
4 participants