-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes good comments link in CONTRIBUTING.md #511
Conversation
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
==========================================
- Coverage 90.25% 88.88% -1.38%
==========================================
Files 24 24
Lines 4004 4004
==========================================
- Hits 3614 3559 -55
- Misses 390 445 +55
Continue to review full report at Codecov.
|
Can you explain the difference between |
I don't have a good explanation for that actually. I just did a quick google search of "coala writing good commits" and stumbled on a link with a very similar domain name and following URL. Anything else I need to check? |
If you want a more recent link, you can use this one: http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html. |
Thanks @Linkid, I will update the link. |
…n PR. This entrypoint ensures that the link in the CONTRIBUTING.md files works as expected and redirects users to the latest instance of the writing good commits page on coala. Closes python-babel#345
@narayanacharya6 Please squash the two commits and we're good to go. :) |
Fixes the dead link with a new link to the same resource. Original issue #345 .