Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes good comments link in CONTRIBUTING.md #511

Merged
merged 2 commits into from
Aug 3, 2017

Conversation

narayanacharya6
Copy link
Contributor

Fixes the dead link with a new link to the same resource. Original issue #345 .

@codecov-io
Copy link

codecov-io commented Jul 11, 2017

Codecov Report

Merging #511 into master will decrease coverage by 1.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
- Coverage   90.25%   88.88%   -1.38%     
==========================================
  Files          24       24              
  Lines        4004     4004              
==========================================
- Hits         3614     3559      -55     
- Misses        390      445      +55
Impacted Files Coverage Δ
babel/_compat.py 53.48% <0%> (-46.52%) ⬇️
babel/localtime/_unix.py 11.53% <0%> (-20.52%) ⬇️
babel/localtime/_win32.py 59.25% <0%> (-3.71%) ⬇️
babel/localtime/__init__.py 62.5% <0%> (-2.5%) ⬇️
babel/messages/catalog.py 92.23% <0%> (-2.39%) ⬇️
babel/util.py 90.47% <0%> (-1.37%) ⬇️
babel/messages/extract.py 94.18% <0%> (-1.1%) ⬇️
babel/localedata.py 94.33% <0%> (-0.95%) ⬇️
babel/support.py 82.28% <0%> (-0.4%) ⬇️
babel/messages/pofile.py 96.38% <0%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c75f29...8c9ab5a. Read the comment docs.

@akx
Copy link
Member

akx commented Jul 12, 2017

Can you explain the difference between coala-red and coala?

@narayanacharya6
Copy link
Contributor Author

I don't have a good explanation for that actually. I just did a quick google search of "coala writing good commits" and stumbled on a link with a very similar domain name and following URL. Anything else I need to check?

@Linkid
Copy link

Linkid commented Jul 16, 2017

If you want a more recent link, you can use this one: http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html.

@narayanacharya6
Copy link
Contributor Author

Thanks @Linkid, I will update the link.

…n PR.

This entrypoint ensures that the link in the CONTRIBUTING.md files works as expected and redirects users to the latest instance of the writing good commits page on coala.

Closes python-babel#345
@akx
Copy link
Member

akx commented Jul 27, 2017

@narayanacharya6 Please squash the two commits and we're good to go. :)

@akx akx merged commit df9111e into python-babel:master Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants