Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse multi-line __future__ imports better #519

Merged
merged 1 commit into from
Aug 21, 2017

Conversation

akx
Copy link
Member

@akx akx commented Aug 18, 2017

Augments #426
Augments #427
Augments #510
Closes #510

@codecov-io
Copy link

codecov-io commented Aug 18, 2017

Codecov Report

Merging #519 into master will decrease coverage by 1.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   90.18%   88.83%   -1.36%     
==========================================
  Files          24       24              
  Lines        4015     4020       +5     
==========================================
- Hits         3621     3571      -50     
- Misses        394      449      +55
Impacted Files Coverage Δ
babel/util.py 90.78% <100%> (-1.05%) ⬇️
babel/_compat.py 53.48% <0%> (-46.52%) ⬇️
babel/localtime/_unix.py 11.53% <0%> (-20.52%) ⬇️
babel/localtime/_win32.py 59.25% <0%> (-3.71%) ⬇️
babel/localtime/__init__.py 62.5% <0%> (-2.5%) ⬇️
babel/messages/catalog.py 92.23% <0%> (-2.39%) ⬇️
babel/messages/extract.py 94.18% <0%> (-1.1%) ⬇️
babel/localedata.py 94.64% <0%> (-0.9%) ⬇️
babel/support.py 82.28% <0%> (-0.4%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1da04fd...43f153a. Read the comment docs.

@akx
Copy link
Member Author

akx commented Aug 18, 2017

@sublee, care to take a look? :)

@sublee
Copy link
Contributor

sublee commented Aug 20, 2017

@akx Looks better.

I suggest you to add more multi-line import styles for unit testing:

from __future__ import (
    print_function,
    division)
from __future__ import \
    print_function, \
    division

@akx
Copy link
Member Author

akx commented Aug 21, 2017

@sublee Thanks! Excellent points -- neither of those cases actually worked. They do now! :)

@akx akx merged commit 231d337 into python-babel:master Aug 21, 2017
@akx akx deleted the multiline-import branch August 21, 2017 13:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants