Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safer PyInstaller support #526

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Safer PyInstaller support #526

merged 1 commit into from
Sep 14, 2017

Conversation

akx
Copy link
Member

@akx akx commented Sep 14, 2017

Also check for sys._MEIPASS before assuming PyInstallerness

Fixes #525

@akx akx added the bug label Sep 14, 2017
@codecov-io
Copy link

codecov-io commented Sep 14, 2017 •
edited
Loading

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #526   +/-   ##
=====================================
  Coverage      90%    90%           
=====================================
  Files          24     24           
  Lines        4024   4024           
=====================================
  Hits         3622   3622           
  Misses        402    402
Impacted Files Coverage Δ
babel/localedata.py 95.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1903a2b...18ea8be. Read the comment docs.

@akx akx merged commit 0b34807 into master Sep 14, 2017
@akx akx deleted the safer-pyinstaller-support branch September 14, 2017 09:47
akx added a commit that referenced this pull request Jan 15, 2018
@akx
Merge pull request #533 from yagebu/fix-pyinstaller
7f4a956 
* Revert "Also check for `sys._MEIPASS` before assuming PyInstallerness (#526)" (0b34807)
* Revert "Merge pull request #505 from wodo/pi_support" (commit 653e6d4, reversing
changes made to 5f3b008)
akx pushed a commit that referenced this pull request Jan 15, 2018
@yagebu @akx
Revert "Also check for sys._MEIPASS before assuming PyInstallerness (…
bdb2f4b 
…#526)"

This reverts commit 0b34807.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijstriemstra thijstriemstra thijstriemstra approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akx @codecov-io @thijstriemstra