Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 2.6 and 3.3 #546

Merged
merged 6 commits into from
Jan 16, 2018
Merged

Drop support for EOL Python 2.6 and 3.3 #546

merged 6 commits into from
Jan 16, 2018

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 28, 2017

Further to #455, I'd like to suggest dropping support for Python 2.6 and 3.3. Both are EOL (2.6 for four years), meaning they no longer receive updates, including security updates.

Removing them will help ease the maintenance burden, and allow to use more modern features of Python. Travis CI will also quicker, from ~23 min run time (total time ~1 hr 4 min) to ~11 min run time (total time ~43 min).

image

https://en.wikipedia.org/wiki/CPython#Version_history

See also:

They're also little used. Here's the pip installs for babel from PyPI for the last month (via pypinfo --percent --pip --markdown babel pyversion).

python_version percent download_count
2.7 75.2% 965,130
3.6 10.8% 139,110
3.5 8.1% 103,400
3.4 5.4% 69,261
2.6 0.2% 2,948
3.3 0.2% 2,069
3.7 0.1% 1,865
3.2 0.0% 55
None 0.0% 17

This PR also adds python_requires to help pip and does some minor tidy ups.

@codecov-io
Copy link

codecov-io commented Dec 28, 2017

Codecov Report

Merging #546 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
- Coverage   90.06%   90.05%   -0.01%     
==========================================
  Files          24       24              
  Lines        4046     4044       -2     
==========================================
- Hits         3644     3642       -2     
  Misses        402      402
Impacted Files Coverage Δ
babel/numbers.py 98% <ø> (-0.02%) ⬇️
babel/messages/checkers.py 64.63% <ø> (ø) ⬆️
babel/plural.py 95.68% <100%> (ø) ⬆️
babel/dates.py 91.24% <100%> (ø) ⬆️
babel/languages.py 100% <100%> (ø) ⬆️
babel/messages/frontend.py 86.25% <100%> (ø) ⬆️
babel/messages/catalog.py 94.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1539c8a...6126d3b. Read the comment docs.

@akx
Copy link
Member

akx commented Jan 16, 2018

This seems alright. Thank you @hugovk :)

@akx akx merged commit 9e1ec18 into python-babel:master Jan 16, 2018
@hugovk hugovk deleted the rm-eol branch January 16, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants