Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import_cldr: ignore non-Latin numbering systems #579

Merged
merged 1 commit into from
May 28, 2018
Merged

Conversation

akx
Copy link
Member

@akx akx commented May 28, 2018

Previously the script could have inadvertently merged formatting rules between numbering systems due to the XML selectors used. This makes sure only Latin rules are used for the time being. When support for other numbering systems is properly added (see #470), these checks can be changed.

Previously the script could have inadvertently merged formatting rules between numbering systems due to the XML selectors used.  This makes sure only Latin rules are used for the time being.  When support for other numbering systems is properly added (see #470), these checks can be changed.
@codecov-io
Copy link

codecov-io commented May 28, 2018

Codecov Report

Merging #579 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #579   +/-   ##
=======================================
  Coverage   90.22%   90.22%           
=======================================
  Files          24       24           
  Lines        4070     4070           
=======================================
  Hits         3672     3672           
  Misses        398      398

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a72cdf1...77dc9d4. Read the comment docs.

@akx akx merged commit 2d0179e into master May 28, 2018
@akx akx deleted the number-sys-import branch May 28, 2018 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants