Using ABCs from collections instead of collections.abc is deprecated. #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And it will stop working in Python 3.8 according to the warning.
Codecov Report
@@ Coverage Diff @@
## master #609 +/- ##
==========================================
+ Coverage 90.31% 90.31% +<.01%
==========================================
Files 24 24
Lines 4128 4129 +1
==========================================
+ Hits 3728 3729 +1
Misses 400 400
Continue to review full report at Codecov.
|
|
Thank you! Very elegant patch. |
Closed
|
It will be good to have a release since the upstream CPython PR is close to getting merged : python/cpython#10596 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And it will stop working in Python 3.8 according to the warning.