Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog update: keep user comments from destination by default #648

Merged
merged 1 commit into from
May 27, 2019

Conversation

akx
Copy link
Member

@akx akx commented May 27, 2019

The assumption here is that the template wouldn't contain user comments to begin with, being autogenerated.

Closes #418 (supersedes; adds tests)

@codecov-io
Copy link

codecov-io commented May 27, 2019

Codecov Report

Merging #648 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
+ Coverage   90.98%   90.98%   +<.01%     
==========================================
  Files          24       24              
  Lines        4169     4171       +2     
==========================================
+ Hits         3793     3795       +2     
  Misses        376      376
Impacted Files Coverage Δ
babel/messages/catalog.py 95.64% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adea98c...f216796. Read the comment docs.

@akx akx merged commit 03215bc into python-babel:master May 27, 2019
@akx akx deleted the retain-user-comments branch May 27, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants