Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix small decimal with disabled decimal_quantization #662

Closed
wants to merge 2 commits into from

Conversation

miluchen
Copy link

@miluchen miluchen commented Aug 19, 2019

Resolves #636
Credits to @llybin

llybin
llybin approved these changes Aug 20, 2019
@miluchen
Copy link
Author

@miluchen miluchen commented Aug 21, 2019

CIs of some other PRs should be fixed by this one.

@codecov-io
Copy link

@codecov-io codecov-io commented Aug 21, 2019

Codecov Report

Merging #662 into master will decrease coverage by 1.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
- Coverage   90.98%   89.75%   -1.23%     
==========================================
  Files          24       24              
  Lines        4173     4121      -52     
==========================================
- Hits         3797     3699      -98     
- Misses        376      422      +46
Impacted Files Coverage Δ
babel/numbers.py 97.68% <100%> (ø) ⬆️
babel/_compat.py 56.86% <0%> (-41.18%) ⬇️
babel/localtime/_unix.py 12.32% <0%> (-10.96%) ⬇️
babel/localtime/_win32.py 59.25% <0%> (-3.71%) ⬇️
babel/localtime/__init__.py 62.5% <0%> (-2.5%) ⬇️
babel/messages/catalog.py 93.35% <0%> (-2.29%) ⬇️
babel/messages/extract.py 94.18% <0%> (-1.1%) ⬇️
babel/localedata.py 94.64% <0%> (-0.9%) ⬇️
babel/core.py 95.51% <0%> (-0.54%) ⬇️
babel/support.py 82.28% <0%> (-0.47%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2abad80...08581c0. Read the comment docs.

@@ -63,6 +63,7 @@ def run(self):
# pytz otherwise does not install on pip 1.4 or
# higher.
'pytz>=2015.7',
'freezegun==0.3.12',
Copy link
Member

@akx akx Dec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a hard requirement for the library, only for the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants