Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way of checking if the catalogs are up-to-date #831

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

kjagiello
Copy link
Contributor

@kjagiello kjagiello commented Jan 26, 2022

I was missing a way to, as a part of CI-pipeline, check if the translations files are up to date. This PRs attempts to implement it in form of a --check flag for pybabel update.

babel/messages/catalog.py Outdated Show resolved Hide resolved
babel/messages/frontend.py Outdated Show resolved Hide resolved
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, seems like a good addition. Some comments around naming and so on...

babel/messages/catalog.py Outdated Show resolved Hide resolved
babel/messages/catalog.py Outdated Show resolved Hide resolved
babel/messages/catalog.py Outdated Show resolved Hide resolved
babel/messages/frontend.py Outdated Show resolved Hide resolved
babel/messages/catalog.py Outdated Show resolved Hide resolved
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in is_identical... :)

babel/messages/catalog.py Outdated Show resolved Hide resolved
@kjagiello
Copy link
Contributor Author

@akx Let me know if there is anything else that needs to be taken care of before we can merge this PR

@akx akx self-requested a review February 20, 2022 14:57
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Could you rebase this?

@kjagiello
Copy link
Contributor Author

Sure thing, done!

@akx
Copy link
Member

akx commented Apr 8, 2022

@kjagiello Tests are unhappy 😭

@kjagiello
Copy link
Contributor Author

kjagiello commented Apr 8, 2022

This will hopefully do the trick! Forgot to do init.

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #831 (1f46a54) into master (4a6e86f) will increase coverage by 0.02%.
The diff coverage is 89.18%.

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   91.09%   91.12%   +0.02%     
==========================================
  Files          23       23              
  Lines        4156     4190      +34     
==========================================
+ Hits         3786     3818      +32     
- Misses        370      372       +2     
Impacted Files Coverage Δ
babel/messages/frontend.py 86.32% <84.61%> (+0.22%) ⬆️
babel/messages/catalog.py 95.43% <100.00%> (+0.13%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akx akx merged commit d2d88da into python-babel:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants