-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement directory filter for extract #832
Conversation
@kinshukdua Can I ask you to review this (as the last person to attempt implementing this in #813)? :) Just so I haven't made any extra silly mistakes here... |
Co-authored-by: Kinshuk Dua <kinshukduaexam@gmail.com>
fd278bc
to
1984ec7
Compare
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
==========================================
+ Coverage 91.09% 91.13% +0.03%
==========================================
Files 23 23
Lines 4123 4139 +16
==========================================
+ Hits 3756 3772 +16
Misses 367 367
Continue to review full report at Codecov.
|
@akx Yes sure, I'll have a look at it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Previosly in function was passed raw value 'self.ignore_dirs', not a list as expected 'ignore_dirs'. Fixes for python-babel#832
Adds multiple value for proper test. Fixes for python-babel#832
Previosly in function was passed raw value 'self.ignore_dirs', not a list as expected 'ignore_dirs'. Fixes for python-babel#832
Adds multiple value for proper test. Fixes for python-babel#832
Adds multiple value for proper test. Fixes for python-babel#832
Adds multiple value for proper test. Follows up on #832
This PR:
directory_filter
callback argument toextract_from_dir
that defaults to the current behavior of ignoring dot and underscore directories--ignore-dirs
(that can be repeated) to replace the default.*
/_*
filtering with other patternsFixes #53 – set
--ignore-dirs
to disable the default dot and underscore filtersFixes #402 – implements it :)
Refs #124 – there is still no way to set this in the mapping configuration file, though (that's #694)
Refs #253 – one could now
--ignore-dirs=node_modules
, for instance.Refs #694 – could be reimplemented on top of this
directory_filter
?Closes #447 – supersedes it
Closes #563 – supersedes it
Closes #761 – you can set
--ignore-dirs='.*'
Closes #813 – supersedes it (thanks for the wording for the CLI parameter!)
Closes #793 – you can set
--ignore-dirs='.* _* venv'