Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plural-Forms: Fix missing trailing semicolon #848

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

farhan5900
Copy link
Contributor

Adds missing semicolon in the code that generates the header that is Catalog.plural_forms as well as in plural.to_gettext function. Also modifies all the concerning test cases as well as test data files.

Closes #836

Adds missing semicolon in the code that generates the header that
is Catalog.plural_forms as well as in plural.to_gettext function.
Also modifies all the concerning test cases as well as test data files.

Closes python-babel#836
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@akx akx added this to the Babel 2.10 milestone Apr 8, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #848 (2988d14) into master (bc7a51b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   91.15%   91.15%           
=======================================
  Files          23       23           
  Lines        4149     4149           
=======================================
  Hits         3782     3782           
  Misses        367      367           
Impacted Files Coverage Δ
babel/messages/catalog.py 95.29% <100.00%> (ø)
babel/plural.py 96.41% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@akx akx merged commit 4a6e86f into python-babel:master Apr 8, 2022
This was referenced Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing trailing semicolon in Plural-Forms header entry
2 participants