diff --git a/cachier/core.py b/cachier/core.py index 83092da2..567c1849 100644 --- a/cachier/core.py +++ b/cachier/core.py @@ -53,7 +53,7 @@ def _function_thread(core, key, func, args, kwds): try: func_res = func(*args, **kwds) core.set_entry(key, func_res) - except BaseException as exc: # pylint: disable=W0703 + except BaseException as exc: print(f"Function call failed with the following exception:\n{exc}") @@ -70,7 +70,6 @@ def _calc_entry(core, key, func, args, kwds): def _default_hash_func(args, kwds): - # pylint: disable-next=protected-access key = functools._make_key(args, kwds, typed=True) hash = hashlib.sha256() for item in key: @@ -229,7 +228,7 @@ def cachier( backend = _default_params["backend"] core: _BaseCore if backend == "pickle": - core = _PickleCore( # pylint: disable=R0204 + core = _PickleCore( hash_func=hash_func, pickle_reload=pickle_reload, cache_dir=cache_dir, @@ -260,7 +259,7 @@ def _cachier_decorator(func): core.set_func(func) @wraps(func) - def func_wrapper(*args, **kwds): # pylint: disable=C0111,R0911 + def func_wrapper(*args, **kwds): nonlocal allow_none _allow_none = ( allow_none @@ -284,7 +283,7 @@ def func_wrapper(*args, **kwds): # pylint: disable=C0111,R0911 key, entry = core.get_entry(tuple(), kwargs) if overwrite_cache: return _calc_entry(core, key, func, args, kwds) - if entry is not None: # pylint: disable=R0101 + if entry is not None: _print("Entry found.") if _allow_none or entry.get("value", None) is not None: _print("Cached result found.") diff --git a/cachier/cores/memory.py b/cachier/cores/memory.py index 798c2209..5f6bb5e9 100644 --- a/cachier/cores/memory.py +++ b/cachier/cores/memory.py @@ -14,7 +14,7 @@ def __init__(self, hash_func, default_params): self.cache = {} self.lock = threading.RLock() - def get_entry_by_key(self, key, reload=False): # pylint: disable=W0221 + def get_entry_by_key(self, key, reload=False): with self.lock: return key, self.cache.get(key, None) diff --git a/cachier/cores/pickle.py b/cachier/cores/pickle.py index 9e7ef54a..43867d8a 100644 --- a/cachier/cores/pickle.py +++ b/cachier/cores/pickle.py @@ -186,7 +186,7 @@ def _save_cache(self, cache, key=None, hash=None): if key is None: self._reload_cache() - def get_entry_by_key(self, key, reload=False): # pylint: disable=W0221 + def get_entry_by_key(self, key, reload=False): with self.lock: if self.separate_files: return key, self._get_cache_by_key(key) diff --git a/tests/test_quality.py b/tests/test_quality.py deleted file mode 100644 index ac2ea3b2..00000000 --- a/tests/test_quality.py +++ /dev/null @@ -1,10 +0,0 @@ -import pytest -import subprocess - - -@pytest.mark.skip # todo: dead check, so let's replace it with Ruff -def test_pylint(): - """Pylint linter passes with no warnings or errors.""" - command = ["pylint"] - parameters = ["--max-line-length=120", "cachier", "tests"] - subprocess.check_call(command + parameters)