Ensure custom zlib include dirs are considered #15

Closed
jcfr opened this Issue Apr 28, 2013 · 2 comments

1 participant

@jcfr

See also #14

@jcfr jcfr was assigned Apr 28, 2013
@jcfr jcfr added a commit that referenced this issue Apr 29, 2013
@jcfr jcfr Explicitly specify zlib include directory
This is particularly important when building python against a custom
version of zlib. It prevents issue when zlib is built with a custom
mangling prefix.

Thanks to Hans Johnson for identifying and fixing the problem.

See #15
e84591d
@jcfr

@hjmjohnson: Let me know if this topic works as expected to build Slicer and SimpleITK. Thanks

@jcfr

Windows build passed: http://open.cdash.org/buildSummary.php?buildid=2889482 (It means that the updated CMake code doesn't cause configure error, building against zlib on windows hasn't been tested yet)

@jcfr jcfr added a commit that referenced this issue Apr 29, 2013
@jcfr jcfr Explicitly specify zlib include directory
This is particularly important when building python against a custom
version of zlib. It prevents issue when zlib is built with a custom
mangling prefix.

Thanks to Hans Johnson for identifying and fixing the problem.

See #15
87d8601
@jcfr jcfr added a commit that referenced this issue May 1, 2013
@jcfr jcfr Fix "binascii" configure error happening when no zlib is found
This commit will prevent the following error from occurring when
configuring using the default option where no zlib is installed on
the system:

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
ZLIB_INCLUDE_DIR (ADVANCED)
   used as include directory in directory C:/D/W/CPython-64-VS2010/Continuous/CPython-64-cl-VS2010-Win64/cmake/extensions
ZLIB_LIBRARY (ADVANCED)
    linked by target "extension_binascii" in directory C:/D/W/CPython-64-VS2010/Continuous/CPython-64-cl-VS2010-Win64/cmake/extensions

See #15
4c146d9
@jcfr jcfr closed this May 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment