From d380c48a6a523d2df659a6e78d50e027ef542122 Mon Sep 17 00:00:00 2001 From: Todd Leonhardt Date: Sat, 8 Jul 2017 14:55:33 -0400 Subject: [PATCH] Added a CODEOWNERS file to automatically nominate code reviewers for pull requests Also added some unit tests related to when default_to_shell is True --- CODEOWNERS | 14 ++++++++++++++ tests/test_cmd2.py | 20 ++++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 CODEOWNERS diff --git a/CODEOWNERS b/CODEOWNERS new file mode 100644 index 000000000..c10568d96 --- /dev/null +++ b/CODEOWNERS @@ -0,0 +1,14 @@ +# Lines starting with '#' are comments. +# Each line is a file pattern followed by one or more owners. +# Owners of code are automatically nominated to review PRs involving that code. + +# These owners will be the default owners for everything in the repo. +* @tleonhardt + +# Order is important. The last matching pattern has the most precedence. +# So if a pull request only touches javascript files, only these owners +# will be requested to review. +#*.js @octocat @github/js + +# You can also use email addresses if you prefer. +#docs/* docs@example.com diff --git a/tests/test_cmd2.py b/tests/test_cmd2.py index 8d91c8efd..ee8f6c870 100644 --- a/tests/test_cmd2.py +++ b/tests/test_cmd2.py @@ -829,6 +829,26 @@ def test_default_to_shell_unknown(shell_app): out = run_cmd(shell_app, unknown_command) assert out == ["*** Unknown syntax: {}".format(unknown_command)] +def test_default_to_shell_good(capsys): + app = cmd2.Cmd() + app.default_to_shell = True + line = 'ls' + statement = app.parser_manager.parsed(line) + retval = app._default(statement) + assert not retval + out, err = capsys.readouterr() + assert out == '' + +def test_default_to_shell_failure(capsys): + app = cmd2.Cmd() + app.default_to_shell = True + line = 'ls does_not_exist.xyz' + statement = app.parser_manager.parsed(line) + retval = app._default(statement) + assert not retval + out, err = capsys.readouterr() + assert out == "*** Unknown syntax: {}\n".format(line) + def test_ansi_prompt_not_esacped(base_app): prompt = '(Cmd) '