Skip to content

Conversation

@ChrisLovering
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for bot-core ready!

Name Link
🔨 Latest commit fe29777
🔍 Latest deploy log https://app.netlify.com/sites/bot-core/deploys/6372846f241dc20008b9cb3a
😎 Deploy Preview https://deploy-preview-162--bot-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ChrisLovering ChrisLovering marked this pull request as ready for review November 14, 2022 17:52
@ChrisLovering ChrisLovering force-pushed the handle-thread-close-on-interactin branch 2 times, most recently from 7362f80 to c5fb2bf Compare November 14, 2022 17:55
@HassanAbouelela
Copy link
Member

These exceptions seem a little too overreaching to be handled by just a debug log. Wouldn't you get HTTPExceptions and NotFound in many other cases, including misconfigurations? We should at least promote to an info/warning logs so we have something to refer to if we need to debug.

@ChrisLovering ChrisLovering force-pushed the handle-thread-close-on-interactin branch from c5fb2bf to 7e17123 Compare November 14, 2022 18:01
@ChrisLovering ChrisLovering force-pushed the handle-thread-close-on-interactin branch from 7e17123 to fe29777 Compare November 14, 2022 18:09
@ChrisLovering ChrisLovering merged commit 3d53d05 into main Nov 14, 2022
@ChrisLovering ChrisLovering deleted the handle-thread-close-on-interactin branch November 14, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants