Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superstarify prison does not release user when it expires #472

Open
SebastiaanZ opened this issue Oct 1, 2019 · 1 comment

Comments

@SebastiaanZ
Copy link
Member

commented Oct 1, 2019

While the superstarify command correctly sends the expiration date of the superstarify prison to the API, it does not schedule a task make sure the infraction is actually deactivated when we reach the expiration date. This means that the user will be kept in superstarify prison until we manually release them with the !unsuperstarify command.

The most obvious solution is to have a superstarify infraction schedule a task like other temporary infractions do. We also need to confirm that this task is recreated if the bot restarts before it was actioned.

Additionally, it's probably a good idea to confirm that the expiration date is in the future before sending a DM to notify a user of their imprisonment when they try to change their nickname or when they rejoin the server. It also wouldn't hurt to add that the datetime string is in UTC.

Context: This notified me of an expiration date in the past (08:21 in my local time):
2019-10-01_08-45

Since @MarkKoz is currently working on the related moderation cog, I've assigned him for now, but I have not yet confirmed that he wants to work on this. Regardless, since we need to schedule this just like regular temporary infractions, it's probably a good idea if he's involved in the discussion.

@MarkKoz

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

Yup, I can work on this.

@sco1 sco1 added this to To Do in Bot Tracking Oct 1, 2019
@sco1 sco1 moved this from To Do to In progress in Bot Tracking Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bot Tracking
  
In progress
2 participants
You can’t perform that action at this time.