Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Superstarify prison does not release user when it expires #472
While the superstarify command correctly sends the expiration date of the superstarify prison to the API, it does not schedule a task make sure the infraction is actually deactivated when we reach the expiration date. This means that the user will be kept in superstarify prison until we manually release them with the
The most obvious solution is to have a superstarify infraction schedule a task like other temporary infractions do. We also need to confirm that this task is recreated if the bot restarts before it was actioned.
Additionally, it's probably a good idea to confirm that the expiration date is in the future before sending a DM to notify a user of their imprisonment when they try to change their nickname or when they rejoin the server. It also wouldn't hurt to add that the datetime string is in UTC.
Since @MarkKoz is currently working on the related moderation cog, I've assigned him for now, but I have not yet confirmed that he wants to work on this. Regardless, since we need to schedule this just like regular temporary infractions, it's probably a good idea if he's involved in the discussion.