Skip to content

Relay the moderator's reason for !superstarify to the user#1319

Merged
Den4200 merged 6 commits into
masterfrom
swfarnsworth/superstar
Dec 9, 2020
Merged

Relay the moderator's reason for !superstarify to the user#1319
Den4200 merged 6 commits into
masterfrom
swfarnsworth/superstar

Conversation

@swfarnsworth
Copy link
Copy Markdown
Contributor

@swfarnsworth swfarnsworth commented Dec 6, 2020

This PR closes issue #1224.

Previously, when a moderator used the !superstarify command, the reason they gave only gets recorded in the user's infraction history and is not relayed to the user in the direct message sent by the bot. This PR changes the message the user is sent to fix this.

However, we're discussing if the special embed that gets posted in the channel where the command is issued is actually appropriate.

image

Previously, the infraction DM from the bot gave a formulaic message about the nickname policy. It now gives a slightly different message along with the reason given by the mod. This means that the message the user gets and the infraction reason that gets recorded are now the same.
Whereas one of my previous commits makes the message the user gets and the infraction that gets recorded the same, the recorded infraction is now shorter, but the message the user gets is more similar to the embed posted in the public channel. We also softened the language of the user-facing message a bit.
@ghost ghost added the needs 2 approvals label Dec 6, 2020
@swfarnsworth swfarnsworth added the a: moderation Related to community moderation functionality: (moderation, defcon, verification) label Dec 6, 2020
@swfarnsworth swfarnsworth linked an issue Dec 6, 2020 that may be closed by this pull request
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 6, 2020

Coverage Status

Coverage remained the same at 56.533% when pulling 66ea30b on swfarnsworth/superstar into ffa8ccb on master.

@swfarnsworth
Copy link
Copy Markdown
Contributor Author

Here's an alternative message (I have not committed or pushed this yet):

image

This is the DM that they get:
image

This is what the mod would see in the user's infraction history:
image

@swfarnsworth
Copy link
Copy Markdown
Contributor Author

Per @mbaruh's suggestion, I made another change whereby the "Additional details: " portion of the message does not appear in the embed displayed in the channel (since it's just restating what the mod wrote in the command), whereas the message still appears in the message sent to the user. The messages are otherwise the same.

@swfarnsworth
Copy link
Copy Markdown
Contributor Author

image

Per an internal discussion, we'll retain the original wording of the embed, but the title will still be "Superstarify!" instead of "Congratulations!"

Comment thread bot/exts/moderation/infraction/superstarify.py
Comment thread bot/exts/moderation/infraction/superstarify.py
Comment thread bot/exts/moderation/infraction/superstarify.py Outdated
@ghost ghost added s: waiting for author Waiting for author to address a review or respond to a comment and removed needs 2 approvals labels Dec 7, 2020
@swfarnsworth swfarnsworth marked this pull request as draft December 7, 2020 15:35
… "Superstarified!"

Per internal staff discussion, we'll keep the wording of the message.
@swfarnsworth
Copy link
Copy Markdown
Contributor Author

The public embed is always the same:
image

The infraction message depends on whether or not the mod gave a reason:
image

image

The message in the infraction history is unchanged from the previous set of screenshots.

@swfarnsworth swfarnsworth marked this pull request as ready for review December 7, 2020 17:16
@swfarnsworth swfarnsworth requested a review from Den4200 as a code owner December 7, 2020 17:16
@ghost ghost added needs 2 approvals and removed s: waiting for author Waiting for author to address a review or respond to a comment labels Dec 7, 2020
Copy link
Copy Markdown
Member

@Den4200 Den4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!

f"You will be unable to change your nickname until **{expiry_str}**. "
"If you're confused by this, please read our "
f"[official nickname policy]({NICKNAME_POLICY_URL})."
).format
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit unconventional and odd, but it's quite smart.

@ghost ghost removed the needs 1 approval label Dec 8, 2020
@Den4200 Den4200 merged commit 287b9f7 into master Dec 9, 2020
@Den4200 Den4200 deleted the swfarnsworth/superstar branch December 9, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: moderation Related to community moderation functionality: (moderation, defcon, verification)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improving Superstar command

5 participants