Relay the moderator's reason for !superstarify to the user#1319
Merged
Conversation
Previously, the infraction DM from the bot gave a formulaic message about the nickname policy. It now gives a slightly different message along with the reason given by the mod. This means that the message the user gets and the infraction reason that gets recorded are now the same.
…wfarnsworth/superstar
Whereas one of my previous commits makes the message the user gets and the infraction that gets recorded the same, the recorded infraction is now shorter, but the message the user gets is more similar to the embed posted in the public channel. We also softened the language of the user-facing message a bit.
Contributor
Author
Contributor
Author
|
Per @mbaruh's suggestion, I made another change whereby the "Additional details: " portion of the message does not appear in the embed displayed in the channel (since it's just restating what the mod wrote in the command), whereas the message still appears in the message sent to the user. The messages are otherwise the same. |
Contributor
Author
HassanAbouelela
suggested changes
Dec 7, 2020
… "Superstarified!" Per internal staff discussion, we'll keep the wording of the message.
Contributor
Author
Den4200
approved these changes
Dec 8, 2020
| f"You will be unable to change your nickname until **{expiry_str}**. " | ||
| "If you're confused by this, please read our " | ||
| f"[official nickname policy]({NICKNAME_POLICY_URL})." | ||
| ).format |
Member
There was a problem hiding this comment.
This feels a bit unconventional and odd, but it's quite smart.
mbaruh
approved these changes
Dec 8, 2020
HassanAbouelela
approved these changes
Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







This PR closes issue #1224.
Previously, when a moderator used the
!superstarifycommand, the reason they gave only gets recorded in the user's infraction history and is not relayed to the user in the direct message sent by the bot. This PR changes the message the user is sent to fix this.However, we're discussing if the special embed that gets posted in the channel where the command is issued is actually appropriate.