Skip to content

Manual verification with !verify sends the user the confirmation DM. #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ks129 merged 8 commits into from
Dec 24, 2020
Merged

Manual verification with !verify sends the user the confirmation DM. #1328

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fc1f7ac
User gets the bot DM when verified via `!verify`.
swfarnsworth Dec 18, 2020
2b09d73
Responses from the bot mention the user.
swfarnsworth Dec 18, 2020
2b73df6
Merge branch 'master' of https://github.com/python-discord/bot into s…
swfarnsworth Dec 20, 2020
ce46567
Rewrite `!verify` to account for new native-gate-only verification.
swfarnsworth Dec 23, 2020
e565515
Merge branch 'master' of https://github.com/python-discord/bot into s…
swfarnsworth Dec 23, 2020
c79626e
Merge branch 'master' of https://github.com/python-discord/bot into s…
swfarnsworth Dec 23, 2020
f397102
`ALTERNATE_VERIFIED_MESSAGE`: "You're" -> "You are".
swfarnsworth Dec 23, 2020
68cbca0
`if user.pending` -> `if not user.pending`
swfarnsworth Dec 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions bot/exts/moderation/verification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"""

ALTERNATE_VERIFIED_MESSAGE = f"""
Thanks for accepting our rules!
You are now verified!

You can find a copy of our rules for reference at <https://pythondiscord.com/pages/rules>.

Expand Down Expand Up @@ -834,19 +834,21 @@ async def bot_check(ctx: Context) -> bool:

@command(name='verify')
@has_any_role(*constants.MODERATION_ROLES)
async def apply_developer_role(self, ctx: Context, user: discord.Member) -> None:
"""Command for moderators to apply the Developer role to any user."""
async def perform_manual_verification(self, ctx: Context, user: discord.Member) -> None:
"""Command for moderators to verify any user."""
log.trace(f'verify command called by {ctx.author} for {user.id}.')
developer_role = self.bot.get_guild(constants.Guild.id).get_role(constants.Roles.verified)

if developer_role in user.roles:
log.trace(f'{user.id} is already a developer, aborting.')
await ctx.send(f'{constants.Emojis.cross_mark} {user} is already a developer.')
if not user.pending:
log.trace(f'{user.id} is already verified, aborting.')
await ctx.send(f'{constants.Emojis.cross_mark} {user.mention} is already verified.')
return

await user.add_roles(developer_role)
log.trace(f'Developer role successfully applied to {user.id}')
await ctx.send(f'{constants.Emojis.check_mark} Developer role applied to {user}.')
# Adding a role automatically verifies the user, so we add and remove the Announcements role.
temporary_role = self.bot.get_guild(constants.Guild.id).get_role(constants.Roles.announcements)
await user.add_roles(temporary_role)
await user.remove_roles(temporary_role)
log.trace(f'{user.id} manually verified.')
await ctx.send(f'{constants.Emojis.check_mark} {user.mention} is now verified.')

# endregion

Expand Down