Talentpool Cleanup#2307
Merged
Merged
Conversation
Bugs fixed were just ones introduced in my last commit :(
wookie184
added
a: recruitment
shtlrs
reviewed
Oct 23, 2022
Contributor
shtlrs
left a comment
shtlrs
left a comment
There was a problem hiding this comment.
I'm no expert in this particular feature, but it LGTM !
Also fixed a docstring and renamed a variable
shtlrs
approved these changes
Oct 23, 2022
ionite34
suggested changes
Nov 5, 2022
ChrisLovering
approved these changes
Nov 5, 2022
Member
ChrisLovering
left a comment
ChrisLovering
left a comment
There was a problem hiding this comment.
Looks great wookie, should be much easier to maintain now that it has typing!
Nice use of match case too.
Contributor
Author
|
Thanks for the reviews :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2306. Tested and ready for review!
Sorry for the big diff, it's not that bad I promise.
Marked as high priority as this blocks other changes to talentpool stuff.