New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AntiSpam Mute Infraction #232

Merged
merged 6 commits into from Jan 11, 2019

Conversation

3 participants
@sco1
Copy link
Member

sco1 commented Dec 29, 2018

Addresses the remaining item in #148: Utilizes a temporary mute infraction rather than having the mute be totally contained by the AntiSpam coro, preventing non-administrators from removing the muted role in the event of a false-positive.

Because I'm having issues getting the local site/bot deployment working, this is considered a WIP until it can be tested by either myself or another contributor.

Closes: #148

sco1 added some commits Dec 29, 2018

Add optional return to modlog post coro
Enables generation of a context for AntiSpam to reference for posting infractions

@sco1 sco1 added this to Needs review in Bot Tracking Jan 4, 2019

@sco1 sco1 moved this from Needs review to In progress in Bot Tracking Jan 4, 2019

sco1 added some commits Jan 6, 2019

Antispam Infraction Fixes
Add muted role object to cog attributes
Fix unawaited coroutine in modlog
Adjust modlog message ctx variable to be more explicit
Fix duration being sent to API as integer instead of string
Fix temporary infraction being placed into a nonexistent schedule, now placed into the moderation cog's task schedule

@sco1 sco1 changed the title WIP: AntiSpam Mute Infraction AntiSpam Mute Infraction Jan 6, 2019

@sco1 sco1 moved this from In progress to Needs review in Bot Tracking Jan 6, 2019

@sco1 sco1 changed the title AntiSpam Mute Infraction WIP: AntiSpam Mute Infraction Jan 6, 2019

@sco1 sco1 changed the title WIP: AntiSpam Mute Infraction AntiSpam Mute Infraction Jan 6, 2019

@sco1 sco1 removed the work in progress label Jan 6, 2019

@sco1

This comment has been minimized.

Copy link
Member

sco1 commented Jan 6, 2019

Antispam now directly invokes the Moderation cog's tempmute so the infraction is reversible. This also gives the added benefit of not having to maintain essentially the same infraction code in two separate cogs.

image
image

@GhostofGoes

This comment has been minimized.

Copy link
Member

GhostofGoes commented Jan 10, 2019

@sco1 Could you resolve the conflicts?

@sco1

This comment has been minimized.

Copy link
Member

sco1 commented Jan 10, 2019

Done

@GhostofGoes

This comment has been minimized.

Copy link
Member

GhostofGoes commented Jan 11, 2019

@SebastiaanZ Can you approve the conflict resolution changes?

Bot Tracking automation moved this from Needs review to Reviewer approved Jan 11, 2019

@SebastiaanZ SebastiaanZ merged commit 163fb3f into master Jan 11, 2019

Bot Tracking automation moved this from Reviewer approved to Done Jan 11, 2019

@SebastiaanZ SebastiaanZ deleted the antispam-mute-infr branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment