New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopefully the final fix to the code block on-edit deletion thing #249

Merged
merged 3 commits into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@LordHemlock
Copy link
Contributor

LordHemlock commented Jan 3, 2019

Thanks to Chib, it looks like the code block message deletion thing after someone fixes their code in chat should be working properly now. For real this time.

Signed-off-by: Daniel Brown browndj3@gmail.com

Hopefully the final fix to the code block on-edit deletion thing
Signed-off-by: Daniel Brown <browndj3@gmail.com>
@tagptroll1
Copy link
Contributor

tagptroll1 left a comment

👍

@SebastiaanZ
Copy link
Member

SebastiaanZ left a comment

Functionality works for me, but maybe you should log the bot's action when it detects an edit and deletes its own message.

Should have added that as a comment, not a change request

Added a log message to go along with messages bot messages being remo…
…ved.

Signed-off-by: Daniel Brown <browndj3@gmail.com>
@SebastiaanZ
Copy link
Member

SebastiaanZ left a comment

Looks good! Thanks for the addition of logging.

@tagptroll1
Copy link
Contributor

tagptroll1 left a comment

Dis is my approval of your improval

@tagptroll1 tagptroll1 merged commit 450a580 into master Jan 3, 2019

@LordHemlock LordHemlock deleted the hemlock/codeblock_retribution branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment