New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwatch reason / Nomination improvements #307

Open
wants to merge 9 commits into
base: master
from

Conversation

2 participants
@SebastiaanZ
Copy link
Member

SebastiaanZ commented Feb 8, 2019

This PR is meant to do a couple of things:

  • As requested by @heavysaturn, unwatching (both bb and talent-pool) a user now requires a reason; the reason will be added as a note the user's record.
  • Previously, a double bb watch would overwrite the old reason; this PR prevents that and notifies the actor.
  • Information on how long a user has been in BB is now added to the header
  • Previously, a nomination could overwrite a bb-watch; I've added a check for that.
  • If a user receives a secondary nomination, then that will no longer overwrite the initial nomination and time. Instead, additional nominations will be added as a note with the prefix "Additional nomination: "
  • To ensure the cache is up to date before checking if a user is already watched/nominated, the cache is updated. To do so, I moved the updating functionality out of the !watched command to a separate function to keep it DRY.

This should close #290 and the in-channel request by Lemon.

Note: Users who are currently nominated will lose their reason, as I've updated the prefix. I'll manually edit their notes later to update them to the current prefix.

SebastiaanZ added some commits Feb 8, 2019

@SebastiaanZ

This comment has been minimized.

Copy link
Member Author

SebastiaanZ commented Feb 8, 2019

I forgot to include the check for current staff members for the nomination command. I'll add it.

@SebastiaanZ SebastiaanZ added this to Needs review in Bot Tracking via automation Feb 8, 2019

@sco1
Copy link
Member

sco1 left a comment

Minor change to user feedback, otherwise works great

Show resolved Hide resolved bot/cogs/bigbrother.py Outdated
Changing negative bot response in nominate command to be more explici…
…t about current bb-status of nominated user
@sco1

sco1 approved these changes Feb 9, 2019

SebastiaanZ added some commits Feb 17, 2019

@SebastiaanZ SebastiaanZ changed the title Bb improvements Unwatch reason / Nomination improvements Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment