Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement !zen command. #643

Merged
merged 7 commits into from Mar 5, 2020
Merged

implement !zen command. #643

merged 7 commits into from Mar 5, 2020

Conversation

@kingdom5500
Copy link
Contributor

kingdom5500 commented Nov 2, 2019

resolves #642.

image

Copy link
Member

kosayoda left a comment

big zen

bot/cogs/utils.py Outdated Show resolved Hide resolved
bot/cogs/utils.py Outdated Show resolved Hide resolved
bot/cogs/utils.py Outdated Show resolved Hide resolved
- return None from the command's coroutine as hinted, rather than a discord.Message object.
- only check for one negative sign on !zen index searches (rather than any amount) so that `int(...)` does not fail.
- provide a range of valid indices when a user requests a !zen index out of range.
bot/cogs/utils.py Outdated Show resolved Hide resolved
bot/cogs/utils.py Outdated Show resolved Hide resolved
@MarkKoz

This comment has been minimized.

Copy link
Member

MarkKoz commented Dec 11, 2019

@kingdom5500 any updates on this?

@scragly

This comment has been minimized.

Copy link
Member

scragly commented Dec 12, 2019

A conflict was introduced here due to #681
Conflict has been resolved.

MarkKoz and others added 2 commits Dec 12, 2019
@scragly scragly requested a review from python-discord/core-developers as a code owner Mar 5, 2020
@scragly scragly requested review from MarkKoz and dementati and removed request for python-discord/core-developers Mar 5, 2020
@sco1
sco1 approved these changes Mar 5, 2020
scragly added 2 commits Mar 5, 2020
@scragly scragly dismissed stale reviews from MarkKoz and kosayoda Mar 5, 2020

Suggested changes have been addressed.

Copy link
Member

SebastiaanZ left a comment

!zen approve

@scragly scragly merged commit 0c36c56 into master Mar 5, 2020
2 checks passed
2 checks passed
Bot Build #20200305.9 succeeded
Details
Bot (Lint & Test) Lint & Test succeeded
Details
@scragly scragly deleted the zen-command branch Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

7 participants
You can’t perform that action at this time.