Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update discord.py to 1.3.1 #743

Merged
merged 2 commits into from Feb 7, 2020
Merged

Update discord.py to 1.3.1 #743

merged 2 commits into from Feb 7, 2020

Conversation

@MarkKoz
Copy link
Member

MarkKoz commented Feb 7, 2020

Related to #734. This PR only updated the dependency.

Note that production was already on 1.3.1 due to using ~=1.2 for the version which is equivalent to >= 1.2, == 1.* (1.3 is permitted by the latter portion of the clause). Should this be stricter going forward e.g. ~= 1.3.1?

@MarkKoz MarkKoz requested a review from python-discord/core-developers as a code owner Feb 7, 2020
@MarkKoz MarkKoz requested review from dementati and lemonsaurus and removed request for python-discord/core-developers Feb 7, 2020
@sco1

This comment has been minimized.

Copy link
Member

sco1 commented Feb 7, 2020

~=1.3.1 makes sense, didn't notice that it got bumped in the lock file when we relocked for #737.

I guess now we know that everything is probably maybe working fine 👍

@eivl
eivl approved these changes Feb 7, 2020
@MarkKoz MarkKoz merged commit 552048d into master Feb 7, 2020
2 checks passed
2 checks passed
Bot Build #20200207.5 succeeded
Details
Bot (Lint & Test) Lint & Test succeeded
Details
@MarkKoz MarkKoz deleted the dep/b734/discord.py-1.3 branch Feb 7, 2020
@MarkKoz MarkKoz removed request for dementati and lemonsaurus Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.