Skip to content
This repository was archived by the owner on Mar 31, 2020. It is now read-only.

Conversation

@syntaxaire
Copy link

No description provided.

syntaxaire and others added 30 commits February 21, 2019 21:34
@lemonsaurus
Copy link
Member

lemonsaurus commented Mar 5, 2019

It's a shame that the QT designer generates such ugly code, but overall this is a big pull request with lots of interesting stuff going on. I love that you guys are using stuff like pathlib and that you went as far as to make some art for the project.

For the most part, the code is inoffensive, but it does appear to be a bit blocky here and there, and could probably benefit from some extra readability.

Overall a very interesting pull request. Can't wait to test it out on Sunday.

@syntaxaire
Copy link
Author

@heavysaturn Thanks for the quick review.

I just want to highlight that our code does use unit tests, but due to the nature of Qt programming most of the methods have side effects, so only a few pure functions are tested.

I posted a patch in code jam chat for integrating unit tests into the Azure build pass/fail but as far as I know ours was the only team to actually do it.

For Sunday, without spoiling anything, all I can say is that it'll launch and run for you, but have fun actually getting into the app... some light reading may be required. This app hates you.

Brycen Addison added 4 commits March 13, 2019 13:45
Troubleshooter just a little bit more annoying and realistic now.
Decreased probabilty per keypress from 10 percent to 5 percent
@syntaxaire syntaxaire closed this Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants