Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.nasa command to get random facts from NASA #358

Closed
SurajBhari opened this issue Feb 24, 2020 · 1 comment · Fixed by #364
Closed

.nasa command to get random facts from NASA #358

SurajBhari opened this issue Feb 24, 2020 · 1 comment · Fixed by #364
Labels
status: approved The issue has received a core developer's approval type: feature Relating to the functionality of the application.

Comments

@SurajBhari
Copy link
Contributor

SurajBhari commented Feb 24, 2020

Description

This command will retrieve a random fact from NASA's API , this can be anything.
Implementation similar to #357

Reasoning

Looks nice, similar to .games and .movies commands.

Proposed Implementation

Use NASA's API and json to get a embed and send it . very easy
Also we will need a constant as nasa API's Auth key.

Additional Details

image
image
image
image

Would you like to implement this yourself?

  • [] I'd like to implement this feature myself
@SurajBhari SurajBhari added status: planning Discussing details type: feature Relating to the functionality of the application. labels Feb 24, 2020
@sco1
Copy link
Contributor

sco1 commented Feb 25, 2020

All of these (#357, #358, #359, #360) look fine. Rather than implementing these as individual cogs, they should ultimately end up being contained inside one cog and implemented as subcommands.

With that in mind, please take a look at their respective APIs and see if there is any functionality that could be implemented for each beyond just returning a random picture. Are there any "generes" or other filters that we could use? Photos from specific missions? Specific topic araeas? etc.

@sco1 sco1 added status: approved The issue has received a core developer's approval and removed status: planning Discussing details labels Feb 25, 2020
@sco1 sco1 added this to Approved in Seasonalbot Tracking Feb 25, 2020
@SurajBhari SurajBhari mentioned this issue Feb 27, 2020
4 tasks
@ks129 ks129 mentioned this issue Feb 29, 2020
4 tasks
Seasonalbot Tracking automation moved this from Approved to Done Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: approved The issue has received a core developer's approval type: feature Relating to the functionality of the application.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants