Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the Snakes and Ladders game #249

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@SebastiaanZ
Copy link
Member

commented Aug 5, 2019

The Snakes and Ladders game in the snake cog was broken because the BytesIO stream of the generated board image was handled incorrectly. This lead to the ValueError: embedded null byte exception we've seen before on another other older feature. (My guess is that a breaking change somewhere broke these relatively old pieces of code that did work before.)

I fixed it by replacing the lines handling the BytesIO stream with an existing utility function that does precisely what's needed and was already defined just above the lines containing the bug.

@lemonsaurus
Copy link
Member

left a comment

Yep, that looks great.

@MarkKoz

MarkKoz approved these changes Aug 5, 2019

@SebastiaanZ SebastiaanZ merged commit e906696 into master Aug 5, 2019

3 checks passed

Seasonal Bot Build #20190805.1 succeeded
Details
Seasonal Bot (Build containers) Build containers succeeded
Details
Seasonal Bot (Lint & Test) Lint & Test succeeded
Details

@SebastiaanZ SebastiaanZ deleted the snakes-and-ladders-bytesio-fix branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.