Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacktober date range and channel whitelist fixes #285

Merged

Conversation

@Numerlor
Copy link
Contributor

commented Oct 1, 2019

This PR extends the date ranges of the search query to cover the beginning of October in the first timezone and the end in the last timezone;
Adds the 2019 Hacktoberfest channel to the white-list for bot commands.

Closes #282 #283

@lemonsaurus

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

@Numerlor Hey, thanks for the PR! This is more or less the right idea, but not quite right. I'd like to allow only the .hacktoberstats command in this channel, not all seasonalbot commands.

Instead of adding this channel to the whitelist constant that's used everywhere, maybe just append this channel to the whitelist on that specific command

@Numerlor

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

Changed the white-list behavior but I'm not sure if it's the right way, had some trouble because the command is a group and now it checks 2 times, with the global and then for the hacktober + whitelist again

Copy link
Member

left a comment

I think with the changes we discussed in the channel now present, this looks good. Also, the implementation is quite good, this clearly isn't your first rodeo.

@Numerlor

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Added logging in case the overridden check fails that I didn't notice yesterday

@SebastiaanZ SebastiaanZ merged commit 1974164 into python-discord:master Oct 2, 2019
2 checks passed
2 checks passed
Seasonal Bot Build #20191002.6 succeeded
Details
Seasonal Bot (Lint & Test) Lint & Test succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.